Skip to content

implemented single linkage clustering #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 3, 2025
Merged

implemented single linkage clustering #313

merged 5 commits into from
Jul 3, 2025

Conversation

DanielLacina
Copy link
Contributor

No description provided.

@DanielLacina DanielLacina requested a review from Mec-iS as a code owner July 1, 2025 19:22
@Mec-iS
Copy link
Collaborator

Mec-iS commented Jul 3, 2025

good work! I am reviewing it now 👍🏼

@Mec-iS
Copy link
Collaborator

Mec-iS commented Jul 3, 2025

please merge DanielLacina#1

@DanielLacina
Copy link
Contributor Author

Alright. It was the best I could do.

@DanielLacina
Copy link
Contributor Author

Merged

@codecov Codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 35 lines in your changes missing coverage. Please review.

Project coverage is 46.00%. Comparing base (239c004) to head (0c6835a).
Report is 9 commits behind head on development.

Files with missing lines Patch % Lines
src/cluster/agglomerative.rs 44.44% 35 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           development     #313      +/-   ##
===============================================
+ Coverage        45.49%   46.00%   +0.50%     
===============================================
  Files               85       87       +2     
  Lines             7254     7500     +246     
===============================================
+ Hits              3300     3450     +150     
- Misses            3954     4050      +96

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mec-iS
Copy link
Collaborator

Mec-iS commented Jul 3, 2025

@DanielLacina please run cargo fmt --all -- --check and push the changes, I forgot to run it after my commit

@DanielLacina
Copy link
Contributor Author

fixed

Mec-iS
Mec-iS previously approved these changes Jul 3, 2025
View reviewed changes
Copy link
Collaborator

@Mec-iS Mec-iS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mec-iS
Copy link
Collaborator

Mec-iS commented Jul 3, 2025

please run rustup update and rerun the linter and the formatter. A rule changed in clippy latest version.

@DanielLacina
Copy link
Contributor Author

alright fixed

@DanielLacina
Copy link
Contributor Author

fixed

@Mec-iS
Copy link
Collaborator

Mec-iS commented Jul 3, 2025

thanks

@Mec-iS Mec-iS self-requested a review July 3, 2025 17:05
@Mec-iS Mec-iS merged commit d459c48 into smartcorelib:development Jul 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mec-iS Mec-iS Mec-iS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielLacina @Mec-iS